Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's testing infrastructure by formalizing the process of writing end-to-end tests. It introduces a dedicated skill that standardizes the approach to E2E test creation, ensuring consistency and clarity across new feature coverage, bug reproductions, and regression prevention. This change aims to streamline the development workflow for tests and improve overall test maintainability. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'write-e2e-cases' skill, providing clear documentation for creating end-to-end tests. The changes are well-structured, and a link to the new skill has been added to the E2E README. I have one minor suggestion to improve the formatting in the new skill file for better readability.
There was a problem hiding this comment.
Pull request overview
Adds documentation for a new local agent skill (write-e2e-cases) to guide contributors when creating or updating Rsbuild end-to-end (Playwright) tests.
Changes:
- Document a new local skill for writing/updating E2E test cases.
- Link the E2E README to the new skill documentation for discoverability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
e2e/README.md |
Adds a reference link to the new write-e2e-cases local skill for adding E2E cases. |
.agents/skills/write-e2e-cases/SKILL.md |
Introduces the new skill with steps, case structure guidance, and constraints for adding E2E tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Added a new write-e2e-cases skill for creating end-to-end tests.
Checklist